FS#7555

I've added FS#7555, which allows you to "double click" which would allow one button to be used three different ways: short press, long press, and double press. However, this patch seems to add a delay when selecting, which is annoying. Right now, no keymaps have been configured for double press, so I think is what I'll do is see if anyone has any suggestions as to what could use a 'double click' (works for all buttons, from what it seems) let me know. I think I may try changing the code a little, to see if I can speed it up a little.

7 comments so far

I have one suggestion: Make the Select Button when double clicked to Bookmark the current playing file.

And if the dbl click for the power button work, make it to go the the sleep timer.

Still thinking about the others.

Jeton
September 7th, 2007 at 4:44 am

I installed your build as of last night; I'm pretty sure it was after your inclusion of this patch.

I now note that despite the fact that I have my Sansa set so that the first button press turns on the backlight, this doesn't happen any longer. It now takes a turn of the wheel to turn on the backlight. Believe it or not, this was the source of some consternation until I figured out the wheel part.

Now... is this to do with the patch? Or was this something you'd had in the build before then? I can get used to anything but I'm not sure I like it this way.

David

major_works
September 7th, 2007 at 7:55 am

I've also found that this patch seems to have made button response very sluggish all around, especially when playing games like Xobox where button response is critical.

I'd like to see it dropped if possible.

major_works
September 7th, 2007 at 8:23 am

I always thought it would be cool to have a separate 'ratings' screen like the IPOD does. Maybe double clicking the select button while a song is playing could bring you to this separate screen, where rating is done with scroll wheel. Maybe a separate topic, I don't know how hard that would be to implement.

ara
September 7th, 2007 at 9:03 am

I think the double click feature doesn't justify this annoying button response... It only slows down rockbox.

Velocity
September 7th, 2007 at 10:40 am

Although i second ara's idea about a rating system, i don't think that this patch can do that. There's a need for a specific patch for that.

And if it's causing slowdown, then it's not worth keeping it.

Sorry for the hassle i made while suggesting it. :\

Jeton
September 7th, 2007 at 11:09 am

I agree that it seemed to be a good idea, but because Rockbox waits to see if there's a second click, it slows it down quite a lot. I plan to remove it shortly.

chrisjs169
September 7th, 2007 at 2:01 pm

Leave a Comment

Name (required)

Mail (will not be published) (required)

Website

Comment

Captcha
Enter the letters you see above.