Patch Updates

So far, all the patches except the following are in the build:

To be done:
FS#7417* - Quick Menu - custom_menu.patch
FS#7252 - SubRip (srt) Subtitle Support in mpegplayer - rockbox.mpeg...srt.patch
FS#7076 - Calendar - sansa_calendar.diff
FS#6988* - Video menu (w/ Photo and Record menu)- vidphotorec_menu.patch
FS#6733** - Shutdown menu - 20070729-shutdown.patch

[Rockbox Forums] - Recording Enhancements Pack - recordingenhan...pack.patch

Done:
FS#2720* - Bookmark on idle poweroff and sleep poweroff - bookmark...v2.diff
FS#6796 - Put ymargin into scrollinfo - ymargin_scrollinfo_20070628.patch
FS#7289 - Allow up to 512 WPS images - wps_display_512_bitmaps_svn13664.patch
[custom] - Version - version.patch
[custom] - Boot logo fix - Moves boot logo up 10 pixels so entire logo shows, and removes version information from boot screen (still appears via Rockbox Information)

Ignore the asterisks - it's just a copy and paste from the patch list. The multifont patch (FS#4733) needs to be updated, which I'll do tomorrow. I'm not sure if I'll do the Recording Enhancements Pack - IIRC, that took a while, and it hasn't been in the build, and I haven't heard anyone complain...

I've got to get off soon, but I'll probably do FS#6796 tonight, and hold the others off until tomorrow.

UPDATE: 6796 is done and in the build. Once I have all the patches in, I'm going to go back a week or two and see if there's any other patches I've missed. Once I'm finally up to date, I'll switch the patch list with a dynamic version, so it will always be up to date.

UPDATE: I have five patches left to do, so that shouldn't be too hard to do tomorrow.

12 comments so far

Are there any chances that the “FS#6697 - New dict plugin” patch (of course, its latest version) gets included into the build?

It seems to make the dict plugin much more convenient than it's now.

HaRT
October 2nd, 2007 at 4:36 am

Are there any chances that the “FS#6697 - New dict plugin” patch (of course, its latest version) gets included into the build?

Just added to the build :)

chrisjs169
October 2nd, 2007 at 12:30 pm

Could you see about adding the patch on this page?
http://www.rockbox.org/tracker/task/2911 ? (just scroll down a bit to find the patch).
thanks!

Zim

Zim
October 2nd, 2007 at 4:57 pm

FS#2911 has been added.

EDIT: Actually, I need keymaps.

#define NES_BUTTON_UP BUTTON_UP
#define NES_BUTTON_DOWN BUTTON_DOWN
#define NES_BUTTON_LEFT BUTTON_LEFT
#define NES_BUTTON_RIGHT BUTTON_RIGHT
#define NES_BUTTON_A BUTTON_A
#define NES_BUTTON_B BUTTON_MENU
#define NES_BUTTON_SELECT BUTTON_SELECT
#define NES_BUTTON_START BUTTON_POWER

BUTTON_A and BUTTON_MENU don't exist on the Sansa, but would replacing BUTTON_UP/DOWN with the scrollwheel work, and then NES_BUTTON_A/B be up/down? IIRC, an NES controller has 8 buttons, while the Sansa has 9 - one being the REC. Either way, unless BUTTON_REPEAT is used (probably not a good idea) the scrollwheel will need to be used one way or another.

For the moment, I'll do:
#define NES_BUTTON_UP BUTTON_SCROLL_UP
#define NES_BUTTON_DOWN BUTTON_SCROLL_DOWN
#define NES_BUTTON_LEFT BUTTON_LEFT
#define NES_BUTTON_RIGHT BUTTON_RIGHT
#define NES_BUTTON_A BUTTON_UP
#define NES_BUTTON_B BUTTON_DOWN
#define NES_BUTTON_SELECT BUTTON_SELECT
#define NES_BUTTON_START BUTTON_POWER

and let you test it.

chrisjs169
October 2nd, 2007 at 7:23 pm

> > Are there any chances that the “FS#6697 - New dict plugin” patch (of course, its latest version) gets included into the build?

> Just added to the build

I don't see it on the “Patch list” page. I thought that list was generated programmatically…

Anyway, thanks a lot. I'm eager to have it on my Sansa.

HaRT
October 3rd, 2007 at 4:45 am

>I don't see it on the “Patch list” page. I thought that list was generated programmatically…

That list isn't automatic yet - IIRC, I get out of school early tomorrow, but I know I'm off Friday - if I don't dynamic-ize the patch list page today, it will be either of those two days.

chrisjs169
October 3rd, 2007 at 1:15 pm

hi chrisjs169,

just recieved my e280 and immediately installed your build, everything works fine. you did a great job and i want to thank you for that.
there's one problem left for me. it's the bug with these garbled top two lines on the lcd. there's a working patch out, which fixes this: FS#7692. would be really great if you could add this one.

freki
October 4th, 2007 at 3:43 am

Closed by Michael Sevakis (MikeS)
Wednesday, 05 September 2007, 08:34 GMT
Reason for closing: Accepted
Additional comments about closing: Does the job.

The patch is added to the bootloader, not the build. Which version of sansapatcher did you use? v0.2?

chrisjs169
October 4th, 2007 at 1:24 pm

Sorry for the confusion. I registered on the ABi forums and posted in your thread over there. So you can forget my comment above.

I used v0.2 and will wait until the bug in v0.3 (fails to load OF) is fixed.

Thanks!

freki
October 6th, 2007 at 2:24 am

There's a copy of the bootloader that should work. http://chrisjs.com/downloads/NoSDHC.mi4 disables SDHC detection on startup, which seems to fix the problem for those who have the OF booting issue. Simply add it doing 'sansapatcher -a NoSDHC.mi4' and it should allow the OF to boot while also removing the screen glitch.

chrisjs169
October 6th, 2007 at 9:48 am

How about adding patch that adds delete option to menu for jpeg viewer?
http://www.rockbox.org/tracker/task/7729?pagenum=2
quite an usefull feature.

BukTop
October 7th, 2007 at 8:42 am

At the moment my Sansa isn't working properly, so I'm backing everything up right now. I'll see if I can have the patch in the build in a few minutes.

update: done.

chrisjs169
October 7th, 2007 at 8:53 am

Leave a Comment

Name (required)

Mail (will not be published) (required)

Website

Comment

Captcha
Enter the letters you see above.