I've spent most of the day trying to rebuild the build, but am running into a problem. As I'm sure some have seen on ABi (mostly on page three of one thread: http://anythingbutipod.com/forum/showthread.php?t=23771&page=3) viewports are very close. The problem is, Viewports don't work with any/many of the themes that use the other WPS patches.
Once viewports are accepted, most WPS patches are going to be closed. In addition, because of the huge changes (viewports are one of the largest Rockbox changes in a long time) it's going to be really hard to have parallel features. While FS#2954 is closed, without the viewports patch, only a few hunks fail. With viewports, I end up staring at this when trying to add scrolling margins: http://pastebin.ca/843247
As you can see, almost every hunk in /firmware/drivers fails. This means I either have to not include the viewports patch (meaning, not include it until forced to) or drop the old WPS patches. I'm talking to kugel on IRC (we were originally talking about having a patch to hide menu items - he figured it out before I did) and he's planning to include the custom list patch, and drop the rest. He said he'll port the themes that are in his build, and may port additional ones on request.
I'm most likely going to be doing the same thing as kugel and digi - drop the old WPS patches and include viewports. Because of this, those using old themes will either need to use an older build, or have them ported to use Viewports.
6 comments so far
So what you're saying is, once they get these View-ports all figured out, they'll close all of the old WPS patches. And that means that many (if not all) themes that rely on those patches, including my super awesome theme;{ , will die.
January 5th, 2008 at 7:29 pm
Ooohh... ouch on that pastebin link. Going to Viewports will make your life much easier. The big thing now is converting all the themes that relied on the WPS patches.
January 5th, 2008 at 8:50 pm
Yeah, with 50+ failed hunks, there's no way I'm making it run parallel with viewports.
Zim - that's what I said back in the "warning about wps patches" post - once viewports are accepted* those patches will be closed.
* There was discussion about whether to close them earlier or wait until viewports were committed. Either way, once viewports is in SVN, those patches will be closed. I think the patches that are definitely going to be closed are FS#2954 and FS#5900, though I think others might be as well.
major_works - I agree, one advantage to going to viewports is it will be a lot easier to sync patches, at the expense of having quite a few themes not work until converted. Zim, that means your themes can still work, you just need to port them. Seeing that somehow the build updated while I was rebuilding, I can really say that the build uses viewports, along with Digi's. Kugel has told me that his next build will be using viewports as well, meaning that current themes will only work with old builds and cpchan's build.
January 5th, 2008 at 9:11 pm
Ok, so how exactly can you port themes?
January 6th, 2008 at 9:34 am
From ABi:
Old: %e|x|y|width|fontnumber|fontcolor|
New: %V|x|y|width|height|font|fgcolor|bgcolor|
From FS#8385:
Specifying "0" for font means that that viewport draws text using the built-in (6x8) system font (FONT_SYSFIXED). Note that this font only includes ASCII characters, so isn't suitable for displaying information from tags.
Specifying "1" for font will use the currently selected user font (FONT_UI).
January 6th, 2008 at 3:40 pm
If anyone wants to see an example of a theme with viewports, KratoJet has been ported, and can be found at http://chrisjs.com/upload/viewport/KratoJetVP-v8.zip
January 6th, 2008 at 3:42 pm
Leave a Comment